Repository navigation
Conversation
…alls back on 503 too Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: adssib <[email protected]>
2 tasks done
|
Claude finished @adssib's task in 58s —— View job ✅ Ready to merge. The fix does what #223 asks: Salesforce's 503 now falls back to the archive, and an unreadable living page is now a failed run instead of a skip. Tests cover both, and every check passes. Rules
BugsNone found. Things I checked:
Verified
Non-blocking
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #234
Closes #223
What this changes
What the fetch layer gets (checked):
403;503from Salesforce's CDN (server: AkamaiNetStorage), after the fetch layer's own retries.The source only fell back to a fresh Wayback snapshot on 401/403, so on 2026-11-21 every run failed. A page's reader now names the statuses its provider blocks plain fetches with (
ArchiveWhenBlocked() []int). Salesforce's are 401, 403 and 503. Any other status (404, 429, 500…) still fails the read.A living page that can't be read is a failed run, never "nothing changed" and never a skip. The
noticeskind passed a reader'sErrNothingToReadthrough, so a block page saved in place of the table (or a page that changed shape) read as a skipped version.Readnow returns it as a plain error (errors.Is(err, plugin.ErrNothingToRead)is false), and so is a snapshot the archive can't take. Tested with a failing archive and with an archived "Access Denied" page.A readable official source? Salesforce's docs site has a JSON content API that answers a plain GET:
get_document_content/api_rest/api_rest_eol.htm/en-us/<doc version>, whose newest version is named byget_document/atlas.en-us.api_rest.meta. But it lags the live page. Its newest version (262.0, Summer '26) lists 31.0–66.0 as supported and has no row for the 31.0–40.0 deprecation the live page announces, so it would miss exactly what this source is for. Not used; written down as an alternative inproviders/salesforce.md. The Wayback Machine's own capture of 2026-11-20 holds the current table.#223's checklist
providers/salesforce.md)Read, and an empty read is an error, notErrNothingToReadChecklist
salesforce.json)make checkpassesCalls I made (please check)
Related PRs
🤖 Generated with Claude Code