Repository navigation
Conversation
… samples Co-Authored-By: Claude <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1720 +/- ##
============================================
+ Coverage 73.95% 73.97% +0.02%
Complexity 4823 4823
============================================
Files 490 490
Lines 15033 15033
Branches 1584 1584
============================================
+ Hits 11117 11121 +4
+ Misses 2982 2978 -4
Partials 934 934
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
mwbrooks
left a comment
There was a problem hiding this comment.
✅ Thanks @zimeg! Fixing the samples here is the right spot to get those string types back in slackapi/node-slack-sdk#2878.
| "share_user_id": "", | ||
| "source": "", | ||
| "is_silent_share": false | ||
| } |
There was a problem hiding this comment.
note (non-blocking): Just below this, channels still holds both "" and "C00000000". That mix was on main before #1636, so it is fine to leave here, but it may be worth checking its generated type in the node SDK.
|
📦 Closing in favor of a generator-side fix in slackapi/node-slack-sdk#2878: |
This pull request changes 50 placeholder IDs in the
search.allandsearch.filesresponse samples back to empty strings, so each ID field in these samples holds one kind of value again.Since #1636, fields like
ts,team_id,userandshare_user_idin these two samples mix empty strings with placeholder IDs (U00000000,T00000000,0000000000.000000). slackapi/node-slack-sdk generates its response types from these samples with quicktype, which reads a field with two values repeated many times as an enum. That turnedts?: stringinto'' | '0000000000.000000'and narrowedteam,team_id,user,user_teamandshare_user_idthe same way in slackapi/node-slack-sdk#2878. With every value empty, quicktype keeps these fields asstring, andusergoes back tostringinsearch.alltoo.Changing the empty strings to placeholders instead doesn't work: quicktype then types the field as the single placeholder, such as
user?: 'U00000000'. Only these values change, and no property is added or removed.test_locally.api.methods.SearchTestpasses with the updated samples.Category (place an
xin each of the[ ])Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.
🤖 Generated with Claude Code