Repository navigation
feat(web-api): add webapi response changes as of 2026-11-20 - #2878
Merged
Merged
Conversation
Co-Authored-By: Claude <[email protected]>
Co-Authored-By: Claude <[email protected]>
🦋 Changeset detectedLatest commit: 86e0da2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2878 +/- ##
==========================================
+ Coverage 94.34% 94.52% +0.18%
==========================================
Files 68 68
Lines 10942 10942
Branches 697 697
==========================================
+ Hits 10323 10343 +20
+ Misses 588 572 -16
+ Partials 31 27 -4
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
mwbrooks
requested changes
Nov 20, 2026
mwbrooks
left a comment
Member
There was a problem hiding this comment.
The placeholder enums in search.all and search.files narrow fields that were string on main, so I'd like those fixed before this lands. The rest of the regeneration looks great!
1 of 6 tasks
Co-Authored-By: Claude <[email protected]>
zimeg
marked this pull request as draft
November 20, 2026 03:32
Co-Authored-By: Claude <[email protected]>
mwbrooks
approved these changes
Nov 20, 2026
Co-Authored-By: Claude <[email protected]>
3 tasks done
…egen Co-Authored-By: Claude <[email protected]>
zimeg
changed the base branch from
main
to
zimeg-fix-web-api-generator-placeholders
November 20, 2026 04:04
Co-Authored-By: Claude <[email protected]>
zimeg
marked this pull request as ready for review
November 20, 2026 04:06
Co-Authored-By: Claude <[email protected]>
Co-Authored-By: Claude <[email protected]>
zimeg
changed the base branch from
zimeg-fix-web-api-generator-placeholders
to
main
November 20, 2026 04:22
Co-Authored-By: Claude <[email protected]>
Member
Author
|
🌟 Thanks for the kind review @mwbrooks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request regenerates the
@slack/web-apiresponse types withscripts/generate-web-api-types.shfrom the latestjson-logssamples onmainof slackapi/java-slack-sdk, which includes slackapi/java-slack-sdk#1636 ("add webapi response changes as of 2026-11-20") and slackapi/java-slack-sdk#1718. It stacks on #2879, which keeps the sample placeholders from narrowing the generated types. The response index is unchanged, so every method keeps its export, and the hand-addedadmin.apps.mcp.servers.permissions.*,apps.managed.permissions.setandassistant.search.*types come out the same.Changes by method family:
chat(postMessage,scheduleMessage,stopStream,update),conversations(history,replies,open),files(info,list,remote.*),pins.list,reactions(get,list) andsearch.messages: file objects gain theai_skill_*,ai_summary,is_skill,skill_description,canvas_agent_creator_idandcanvas_default_agent_idfields, block accessories gainagent_prompt,agent_prompt_displayandvisible_to_user_ids, and attachment metadata gains the largerthumb_*sizes.pins.listmessages also gainagent_sessionandlanguage.conversations:listchannels gainlatest(withagent_sessionandlanguage),channel_email_addresses,connected_team_ids,is_open,unread_countand related fields.create,invite,rename,setPurposeandsetTopicgainproperties, andinfogainsis_file.views(open,publish,push,update): block accessories gainagent_prompt,agent_prompt_displayandvisible_to_user_ids.search(all,files): file matches gaincanvas_creator_id,canvas_readtime,is_ai_suggested,show_badgeand privateshares.admin.apps.activities.list: trigger configs gainfunction_inputsas{ [key: string]: FunctionInput }, plustrigger_type_app_idandtrigger_type_id.agents.conversations.listViews: addssession_views.apps:manifest.exportgainsuser_connections,auth_hostsandapp_level_token_rotation_enabled, andicon.setgainsresponse_metadata.canvases.getContentgainsresponse_metadata, andusers.listgainsis_seamless_enabled_app_bot.No property is removed or narrowed. With #2879, the
search.allandsearch.filesID fields staystring, andfunction_inputsis a map instead of having the literal keys'0000000000'and'0000000000_'.Some new fields are typed as empty objects, because their samples hold
{}. These arepropertiesonconversations.create,invite,rename,setPurposeandsetTopic,response_metadataoncanvases.getContent, andknocksonconversations.list.conversations.infoalready has the fullpropertiesshape, and a follow-up can fill these in.Testing
npm run build,npm test(157 tests, the same asmain) andnpm run lintpass forpackages/web-api.tsc --strictcheck assigns each of the 39 changed response types frommainto its regenerated type and back. Only thesearch.allandrtm.startenum widenings from fix(web-api): blank sample placeholders before generating response types #2879 fail.npx tsdreports the same 6 errors here as onmain, all for the removedfiles.uploadandrtm.startmethods.Requirements
🤖 Generated with Claude Code