Skip to content

fix(assistant): propose and show prefixed folder names in English setup and follow-ups - #264

Merged
lweberru merged 1 commit into
mainfrom
fix/assistant-folder-naming
Nov 17, 2026
Merged

lweberru merged 1 commit into
mainfrom
fix/assistant-folder-naming

Conversation

@lweberru

Copy link
Copy Markdown
Collaborator

Closes #263.

Combined company-prefix/folder requests could omit folder names, while naming follow-ups could enter the generic Editor path and show only rm_folders. Foundation summaries also forced German. Route existing-folder naming through a bounded contract that requires concrete names, carries the requested prefix separately and lists the resulting names in the conversation language. Naming-only follow-ups cannot alter unrelated foundation scalars; folder keys, parent bindings and IAM metadata remain unchanged. Assistant-only folder mentions cannot authorize naming during foundation restoration.

Add the two reported English scenarios with synthetic identities, metadata-preservation/scope regression tests, regenerated source-bound knowledge/catalogue and English/German contract documentation.

Validation:

  • Full npm run check passes: knowledge/catalogue freshness, lint, typecheck, web build and 1,836 unit tests; 78 existing tests remain skipped. No database/cloud integration or deployment was performed.
  • Final real-model qualification: foundations-prefixed-folders, governance-prefixed-folders-followup and existing foundations-restoration, each repeated twice independently: 6/6 pass against the dedicated EU01 Qwen/Qwen3-VL-235B-A22B-Instruct-FP8 test model.
  • All six final receipts bind knowledge SHA-256 48967d9f510be61be627a559970720c6f8985afa9de6ef686dc7db635edb7819 and suite SHA-256 b30a7161e52133f2a875758d4b20ef652ed50177a05e53009f71bad0bb930f9f; proposals were applied locally and exported/roundtripped.
  • Earlier development iterations reproduced omissions/no-op folder names, wrong-language output and unintended folder changes during restoration. Those remain failed receipts; the final result is targeted qualification, not qualification of the full Assistant suite or resolution of fix(assistant): structured-output HTTP 400 and incorrect execution-upgrade routing #225.

No production conversations, customer identifiers or deployment credentials were sent to the model. Production installation remains a separate manually initiated release operation.

@lweberru
lweberru merged commit ed59ff9 into main Nov 17, 2026
15 of 16 checks passed
@lweberru
lweberru deleted the fix/assistant-folder-naming branch November 17, 2026 11:35
lweberru added a commit that referenced this pull request Nov 17, 2026
…builds (#265)

The Configurator Release build fails in the PostgreSQL integration suite
after #264: its folder-naming model fixture still returns the old
`changes.rm_folders` response and omits the required structured
`folderNames` field. The early failure leaves its own test configuration
behind, causing the subsequent pooled-identity assertion to see an extra
row for the same test user.

Update the fixture to the current model contract, assert that the
emitted schema requires names for the existing folder keys, and register
test-local cleanup with `onTestFinished` so failure paths also remove
the configuration. Existing assertions for proposal acceptance, identity
preservation, metadata privacy and tenant isolation remain intact.
Application code, model prompts and validation rules are unchanged.

Validation: reproduced both reported failures locally on the exact CI
PostgreSQL image
`postgres@sha256:d74eeac9a635390a49bc21bd49fccd973de707e2a53a76ac49b552b8712ec46f`;
after correction all 55 identity tests pass. The complete CI database
command passes with 223 tests and one existing skip across all 10 files.
Typecheck, changed-file Biome checks and `git diff --check` pass. The
temporary local database container was removed; no cloud deployment or
live model calls were performed.

Follow-up to #263 / #264. Failed release:
https://github.com/stackitcloud/stackit-landing-zone/actions/runs/44075554893/job/134012509901.
That run never reached deployment. After merge, start a new Configurator
Release from updated `main`; rerunning the old run retains its original
source revision.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(assistant): preserve prefixed folder naming in combined requests and English follow-ups

1 participant