Repository navigation
Conversation
Contributor
|
Commit: Regression test reportSelected 20 changed tests (limit=20, 26 not selected) 38 tests: regression=35 unreleased=0 coverage=2 failing=1
TestAccept/bundle/resources/catalogs/rename/DMS=: branch ✅ | main (d1fd7f0) ❌ | latest (v1.25.0) ❌main (d1fd7f0): latest (v1.25.0): TestAccept/bundle/resources/catalogs/rename/DMS=true: branch ✅ | main (d1fd7f0) ❌ | latest (v1.25.0) ❌main (d1fd7f0): latest (v1.25.0): TestAccept/bundle/resources/catalogs/rename_all_out_of_band/DMS=: branch ✅ | main (d1fd7f0) ❌ | latest (v1.25.0) ❌main (d1fd7f0): latest (v1.25.0): 33 more failure details omitted, see the full report in the run. |
Collaborator
✅ Integration test reportCommit: 13aeadd
8 interesting tests: 8 flaky
Top 45 slowest tests (at least 2 minutes):
|
denik
force-pushed
the
denik/models-rename
branch
from
November 5, 2026 15:30
f364f17 to
18077b3
Compare
denik
force-pushed
the
denik/models-rename
branch
7 times, most recently
from
November 9, 2026 13:09
64af993 to
7496114
Compare
denik
force-pushed
the
denik/models-rename
branch
from
November 9, 2026 14:52
7496114 to
132a53d
Compare
denik
force-pushed
the
denik/models-rename
branch
from
November 9, 2026 14:59
132a53d to
b5f68ef
Compare
denik
force-pushed
the
denik/models-rename
branch
4 times, most recently
from
November 10, 2026 13:23
b0476cd to
36755c1
Compare
A registered model's name is now an updatable ID field: a rename sends new_name and keeps the model's versions, instead of deleting and recreating it. A model inside a renamed catalog or schema is re-keyed without a request, like volumes; recreating it failed with RESOURCE_ALREADY_EXISTS. Co-authored-by: Isaac <[email protected]>
Co-authored-by: Isaac <[email protected]>
After an interrupted parent rename the plan reads the model at its stale ID and has no remote state; sync aliases against the model at its new path instead. Co-authored-by: Isaac <[email protected]>
…s with their schema A model missing from its recorded ID is planned as a create again, so DoUpdateWithID always has the plan's remote state. A forced schema or catalog delete in the test server now also deletes the registered models in it, like UC. Co-authored-by: Isaac <[email protected]>
Co-authored-by: Isaac <[email protected]>
Co-authored-by: Isaac <[email protected]>
…; test rename with a comment change Co-authored-by: Isaac <[email protected]>
denik
force-pushed
the
denik/models-rename
branch
from
November 10, 2026 14:14
36755c1 to
13aeadd
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Changing a registered model's
namenow renames it in place (PATCH new_name) instead of deleting and recreating it, so the model keeps its versions. The recreate only matched Terraform, which is gone.A model in a renamed catalog or schema (
schema_name: ${resources.schemas.<s>.name}) now follows its parent the way volumes do in #7343: withIDFromState, the framework re-keys it without a request (state_only). It used to be planned as a recreate whose create failed withRESOURCE_ALREADY_EXISTS(verified on AWS), and every later deploy tried to create it again.UC rejects an update that sets both
nameandnew_name, so a rename leavesnameout (#7408 makes the test server reject it too).Stacked on #7343. UC secrets get the same fix in #7381.
Tests
registered_models/rename(Cloud = true): rename the model, then its schema, then its catalog, then the model again together with its comment (one PATCH).created_atstays the same and the final plan is a no-op.registered_models/basic(Cloud = true, AWS) andmigrate/auto/registered-model-rename: a name change now renames.This pull request and its description were written by Isaac.