Repository navigation
Conversation
Contributor
|
Commit: Regression test reportSelected 20 changed tests (limit=20, 29 not selected) 38 tests: regression=36 unreleased=0 coverage=2 failing=0
TestAccept/bundle/resources/catalogs/rename/DMS=: branch ✅ | main (6a8d9bf) ❌ | latest (v1.25.0) ❌main (6a8d9bf): latest (v1.25.0): TestAccept/bundle/resources/catalogs/rename/DMS=true: branch ✅ | main (6a8d9bf) ❌ | latest (v1.25.0) ❌main (6a8d9bf): latest (v1.25.0): TestAccept/bundle/resources/catalogs/rename_all_out_of_band/DMS=: branch ✅ | main (6a8d9bf) ❌ | latest (v1.25.0) ❌main (6a8d9bf): latest (v1.25.0): 33 more failure details omitted, see the full report in the run. |
Collaborator
✅ Integration test reportCommit: cd48921
8 interesting tests: 8 flaky
Top 50 slowest tests (at least 2 minutes):
|
denik
force-pushed
the
denik/secrets-parent-rename
branch
from
November 6, 2026 11:21
344a6c9 to
24b12d9
Compare
denik
force-pushed
the
denik/secrets-parent-rename
branch
from
November 6, 2026 11:58
24b12d9 to
35b8737
Compare
denik
force-pushed
the
denik/secrets-parent-rename
branch
from
November 6, 2026 12:25
35b8737 to
5bd3516
Compare
denik
force-pushed
the
denik/secrets-parent-rename
branch
from
November 9, 2026 10:06
5bd3516 to
a333a4b
Compare
denik
force-pushed
the
denik/secrets-parent-rename
branch
from
November 9, 2026 10:17
a333a4b to
4ccf5ab
Compare
denik
force-pushed
the
denik/secrets-parent-rename
branch
from
November 9, 2026 11:52
4ccf5ab to
cdc56bf
Compare
denik
force-pushed
the
denik/secrets-parent-rename
branch
from
November 9, 2026 13:12
cdc56bf to
0d1ef07
Compare
This was referenced Nov 9, 2026
denik
force-pushed
the
denik/secrets-parent-rename
branch
from
November 9, 2026 14:52
0d1ef07 to
d16b7c2
Compare
denik
force-pushed
the
denik/secrets-parent-rename
branch
from
November 9, 2026 14:59
d16b7c2 to
5e37c6e
Compare
denik
force-pushed
the
denik/secrets-parent-rename
branch
from
November 9, 2026 15:11
5e37c6e to
2957d38
Compare
denik
force-pushed
the
denik/secrets-parent-rename
branch
from
November 9, 2026 15:43
2957d38 to
ce6daec
Compare
denik
force-pushed
the
denik/secrets-parent-rename
branch
from
November 9, 2026 20:33
ce6daec to
2b74f07
Compare
denik
force-pushed
the
denik/secrets-parent-rename
branch
from
November 10, 2026 13:23
2b74f07 to
7f7dd30
Compare
denik
force-pushed
the
denik/secrets-parent-rename
branch
from
November 10, 2026 14:14
7f7dd30 to
6177b6a
Compare
denik
force-pushed
the
denik/secrets-parent-rename
branch
from
November 10, 2026 15:28
6177b6a to
cd48921
Compare
UC moves a secret with its renamed parent, so the planner now re-keys it (update_id, parent_renamed) instead of recreating it, which failed with ALREADY_EXISTS. A secret cannot be renamed itself, so its DoUpdateWithID only re-keys; the adapter check now accepts DoUpdateWithID for a resource whose provided_id_fields a parent rename can change. Co-authored-by: Isaac <[email protected]>
Co-authored-by: Isaac <[email protected]>
Co-authored-by: Isaac <[email protected]>
Co-authored-by: Isaac <[email protected]>
…t; drop duplicated test-server moves Co-authored-by: Isaac <[email protected]>
The recreate deletes the secret at its recorded path after the schema's rename moved it, so the moved secret is left behind. Co-authored-by: Isaac <[email protected]>
Co-authored-by: Isaac <[email protected]>
Co-authored-by: Isaac <[email protected]>
Co-authored-by: Isaac <[email protected]>
denik
force-pushed
the
denik/secrets-parent-rename
branch
from
November 10, 2026 16:06
cd48921 to
21ac5c2
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
A UC secret in a renamed catalog or schema (
schema_name: ${resources.schemas.<s>.name}) now follows its parent the way volumes do in #7343 and registered models do in #7379: withIDFromState, the framework re-keys it without a request (state_only). It used to be planned as a recreate whose create failed with409 ALREADY_EXISTS(verified on AWS), and every later deploy tried to create it again.UC cannot rename a secret, so its name still recreates. When the secret also has its own changes, the new
DoUpdateWithIDsends the update at the new path. The adapter check used to requireupdatable_id_fieldsfor aDoUpdateWithID; it now also acceptsprovided_id_fields, which a parent rename can change.Stacked on #7379; the test-server support is in #7408.
Tests
secrets/recreate_in_renamed_schema(Cloud = true): rename the schema and the secret in one deploy. The secret is recreated, and the old one is deleted where the schema's rename moved it (the fix is in Support schema rename and improve catalog rename #7343). The test server now reports a missing secret with UC's message.secrets/parent_rename(Cloud = true): rename the schema (no request to the secret), then rename the catalog and change the secret's comment in one deploy (one PATCH at the new path).create_timestays the same and the final plan is a no-op.This pull request and its description were written by Isaac.