Repository navigation
testserver: match Unity Catalog on renames, forced deletes and taken names - #7408
Merged
Merged
Conversation
…names - A renamed catalog moves its schemas, volumes, registered models and secrets; a renamed schema moves its volumes, registered models and secrets. - A forced catalog or schema delete deletes what is in it. - A catalog create under a taken name fails with CATALOG_ALREADY_EXISTS. The two migrate catalog-change scripts no longer create the catalog that their captured replay creates. - A renamed schema or volume gets a lowercased name; a renamed registered model updates its full_name, keeps its versions, and the update rejects name and new_name together. acceptance/cmd/workspace/uc-renames checks these against a real workspace. Co-authored-by: Isaac <[email protected]>
denik
marked this pull request as ready for review
November 9, 2026 14:21
denik
enabled stacked auto-merge
November 9, 2026 14:23
shreyas-goenka
approved these changes
Nov 9, 2026
| @@ -1,9 +1,4 @@ | |||
|
|
|||
| >>> [CLI] catalogs create othercat_[UNIQUE_NAME] -o json | |||
Contributor
Author
There was a problem hiding this comment.
it's a duplicate, we create this catalog in terraform-requests fixture.
Contributor
|
Commit: Regression test reportSelected 3 changed tests (limit=20, 0 not selected) 3 tests: regression=0 unreleased=0 coverage=3 failing=0
|
Co-authored-by: Isaac <[email protected]>
denik
disabled stacked auto-merge
November 9, 2026 14:52
Collaborator
✅ Integration test reportCommit: f1c2da9
Top 3 slowest tests (at least 2 minutes):
|
This was referenced Nov 9, 2026
Collaborator
❌ Integration test reportCommit: df79350
40 interesting tests: 40 FAIL
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Make the test server behave like Unity Catalog where the UC rename PRs depend on it:
CATALOG_ALREADY_EXISTS.full_nameand keeps its versions, and settingnameandnew_namein one update is rejected.The
schema-catalog-changeandregistered-model-catalog-changemigrate scripts created a catalog that their captured replay creates again; the fake now rejects that, so the scripts no longer create it.Tests
New
acceptance/cmd/workspace/uc-renames(Cloud = true) checks each behavior with plain CLI calls. It passes locally and on AWS, GCP and Azure.Next: #7343 (schema rename) stacks on this PR, followed by #7379 and #7381.
This pull request and its description were written by Isaac.