Repository navigation
merge removedmembers into the migrationguide kind (I19.4) - #213
Merged
1 commit merged intoNov 21, 2026
Merged
1 commit merged into
1 commit merged into
Conversation
One kind for a guide that lists what a release removed: the SDK guide and the removed-members readers implement migrationguide.Guide, and one Plugin lists, reads and extracts for both. plugins/removedmembers only forwards now; old kind names resolve through plugin.CanonicalKind. Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: adssib <[email protected]>
2 of 3 tasks
|
Claude finished @adssib's task in 1m 31s —— View job ✅ Ready to merge: a clean refactor. The three sources' metadata moved unchanged, the goldens are exact renames, and every check passes locally. Rules
BugsNone found. I checked behaviour against the old code path by path:
Verified
Non-blocking (optional)
|
This was referenced Nov 20, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #175
What this changes
One kind for "a guide that lists what a release removed" (I19.4).
plugins/migrationguidehas onePluginand oneExtract; a source'sGuideis its reader:sdkguide.Guide(an SDK's removed request parameters) or the newmembers.Guide(a package's removed members, RST or Markdown tables; the oldremovedmemberscode, moved toplugins/migrationguide/members). NumPy, PostHog and New Relic register onmigrationguidenow; their kind in the list ismigrationguide.plugins/removedmembersstays as a deprecated forwarder (types, values,Parse,Plugin = migrationguide.Plugin), soremovedmembers.Plugin{Guide: removedmembers.NumPy2}still compiles; it registers nothing.plugin.CanonicalKind("removedmembers")ismigrationguide(a source registered with the old kind name still passes).new-plugin --format removedmembersscaffolds amembers.Guideonmigrationguide.Acceptance criteria
git diff --stat -M100%: three pure renames, below)ExtractListVersions, not one pinned tag": the SDK guide does; the removed-members guides list every PyPI release but still read the one release theirReleasenames (left for I19.8)Calls I made (please check)
members_test) with a dot import of the reader, plus anexport_test.gofor three unexported helpers: the tests need the kind'sPlugin, which imports the reader.migrationguide.Plugin.Guideis now an interface:Plugin{Guide: …}literals compile, but code readingp.Guide.Packagethrough the old type would not (nothing does).Checks
make checkpasses (tidy, build, gofmt, vet, import allowlist, net/http guard,go test -race, noTODO(new-plugin), leak guard);make contractagainst patch-it'smainfixtures passes (11 files).plugins/{removedmembers => migrationguide}/testdata/golden/{numpy-2.0.0,posthog-8.0.0,newrelic-11.0.0}.json, 0 lines changed); every golden test passes on the moved codeRelated PRs
apps/plugins-repo.md)v0.3.0(see "What the next bump changes" in the combined PR); the contract change this stack prepares for: patch-it-dev/patch-it#58 (adopted in a separate PR after it merges)🤖 Generated with Claude Code