Repository navigation
remove the top-level forwarding packages - #220
Merged
Merged
Conversation
plugin/, event/, fetch/, migrate/, kit/ (and kit/kittest/), retire/ and sdkguide/ only forwarded to core/ and plugins/. Code importing them moves to core/plugin, core/event, core/fetch, core/migrate, core/kit, plugins/notices/retire and plugins/migrationguide/sdkguide. Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: adssib <[email protected]>
|
Claude finished @adssib's task in 48s —— View job ✅ Ready to merge. This PR only deletes code that nothing imports and updates the docs to match. Build, vet, gofmt, tests and the leak guard all pass. Rules
BugsNone found. Nothing in the repo still imports the deleted packages:
Verified
Non-blocking
|
This was referenced Nov 20, 2026
Merged
Signed-off-by: adssib <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: adssib <[email protected]>
- core/event: the v1 ChangeEvent, its fingerprint and core/migrate are gone; every reader builds event.Event (was EventV2) directly. api_operation's kind type is event.Kind. - A source's plugin is named by its id, provider/source, and its events carry that id in api. The old slugs, Alias/Aliases/first_name, Register by slug and Lookup by slug are gone; RegisterProvider refuses a plugin whose Name isn't its source's id. plugins.json drops alias, first_name and aliases. - Replay, Replayer and Spec.Replay are gone: a version pair is ReadAt twice and Extract (kittest.Pair in tests). catalog gains ListVersions, ReadAt and Extract, so every kind is read version by version. - new-plugin: --format, --api and the old meanings of --provider and --source are gone; files are named <provider>-<source>. Goldens regenerated on purpose: api is now the source id, and since the fingerprint hashes api, every fingerprint changed with it. Checked with a script: old and new goldens are identical once api and fingerprint are set aside (three normalize goldens also move from v1's affected to subject). Two notices goldens are renamed to their id (cloudflare-api.json, google-vertex-ai-models.json). Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: adssib <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: adssib <[email protected]>
Signed-off-by: adssib <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: adssib <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: adssib <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: adssib <[email protected]>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #219
Part of #171
What this changes
Deletes the top-level forwarding packages:
plugin/,event/,fetch/,migrate/,kit/(withkit/kittest/),retire/,sdkguide/. Nothing in the repo imports them. The top level is nowcore/ plugins/ cmd/ internal/ docs/ providers/ contract/ scripts/ .github(internal/pluginlistis real code: the list's builder forcmd/list-plugins). AGENTS.md and the docs no longer mention them; the PR template's metadata box names kind and packages.Last in the stack on purpose: code pinned to
v0.3.0is unaffected (it pins a tag); the hosted ingestion service already importscore/*on its bump branch, so the next release breaks nothing it uses. The merged kinds' old paths (plugins/removedmembers,apichangelog,retirements,retirements/retire,feed,eol) stay as forwarders: its tests import them.Checks
make checkpasses (tidy, build, gofmt, vet, import allowlist, net/http guard,go test -race, noTODO(new-plugin), leak guard);make contractagainst patch-it'smainfixtures passes (11 files).Related PRs
apps/plugins-repo.md)v0.3.0(see "What the next bump changes" in the combined PR); the contract change this stack prepares for: patch-it-dev/patch-it#58 (adopted in a separate PR after it merges)🤖 Generated with Claude Code