Repository navigation
merge apichangelog into the changelog kind (I19.5) - #214
Merged
Merged
Conversation
changelog.Plugin reads a Markdown/RST changelog (File) or a JSON one (Log). The JSON one now lists its versions (the commits that changed the file), reads each, and extracts what a commit added. plugins/apichangelog only forwards. Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: adssib <[email protected]>
4 tasks done
|
Claude finished @adssib's task in 1m 8s —— View job ✅ Ready to merge. The move is clean: MongoDB Atlas's registration and golden output are unchanged, the new commit-by-commit path follows the same rules for which changes count as events, and every check passes locally. Rules
BugsNone found. Things I checked in the new pair logic (
Verified
Non-blocking (optional)
|
This was referenced Nov 20, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #213
Closes #176
What this changes
One changelog kind, Markdown/RST or JSON (I19.5).
apichangelogmoves intoplugins/changelogas its JSON parser:changelog.Plugin{Log: changelog.MongoDBAtlas}next toPlugin{File: …}. The JSON changelog now has versions:ListVersionsis the commits that changed the file (versions.GitHubCommits),ReadAtthe file at a commit,Extractthe life-cycle findings the newer commit has that the older didn't.Runreads the newest commit, as before.plugins/apichangelogstays as a deprecated forwarder (Plugin = changelog.Plugin,Log,Finding,MongoDBAtlas);CanonicalKind("apichangelog")ischangelog.Acceptance criteria
TestJSONChangelogPairByPairlists three commits oldest first and extracts the two consecutive pairs (plus the first from nothing, whichRuncovers), each giving only what that commit added. The Markdown side's pair test (TestReleasesAreListedAndExtractedPairByPair) was already there.Calls I made (please check)
versionand leaveprevious_versionempty: a pair of commits is two days of the file, not two releases of the API.File.Atpins only the goldens' cases).Checks
make checkpasses (tidy, build, gofmt, vet, import allowlist, net/http guard,go test -race, noTODO(new-plugin), leak guard);make contractagainst patch-it'smainfixtures passes (11 files).plugins/{apichangelog => changelog}/testdata/golden/mongodb-atlas.json, 0 lines changed)Related PRs
apps/plugins-repo.md)v0.3.0(see "What the next bump changes" in the combined PR); the contract change this stack prepares for: patch-it-dev/patch-it#58 (adopted in a separate PR after it merges)🤖 Generated with Claude Code