Repository navigation
merge retirements, feed and eol into one notices kind (I19.6) - #215
Merged
Merged
Conversation
One Plugin reads every live page of dated notices: fetch, unchanged check, shape guard and blocked-page fallback as reader options, Wayback cite, events, baseline. The deprecations-page, feed and end-of-life readers live under plugins/notices; the RSS/Atom and HTML helpers move to core/extract. The old packages only forward. Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: adssib <[email protected]>
Merged
4 of 6 tasks
|
Claude finished @adssib's task in 1m 22s —— View job ✅ Ready to merge. The merge keeps the same behaviour: the one Rules
BugsNone found. I compared
Verified
Non-blocking
Metadata: I read the six registrations against the base branch, and the words are unchanged and still accurate. |
This was referenced Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #214
Closes #177
What this changes
One
noticeskind for live pages of dated notices (I19.6): the deprecations pages (retirements), the RSS/Atom feeds (feed) and the end-of-life table (eol).plugins/noticeshas onePluginwhoseRundoes the shared steps once: fetch the live page, stop if unchanged, read it, the shape guard, snapshot and cite (kit.Cite), events from the snapshot, baseline. The readers live under it:notices/retire,notices/feed,notices/eol; each implementsnotices.Page(Slug,PageURL,Find,Events).ShapeGuard()(fewer than 90% of the last read's notices is an error; the deprecations pages) andArchiveWhenBlocked()(a 401/403 live page is read from a fresh Wayback snapshot; Salesforce).core/extract(notices/feedkeeps its names as aliases).kit.Noticesis what a reader returns.plugins/retirements,plugins/retirements/retire,plugins/feed,plugins/eolstay as deprecated forwarders:retirements.Plugin{Page, Archiver},eol.Plugin{Page: eol.Salesforce, Archiver}andfeed.Plugin{Feed, Archiver}still compile and run the same events (tested).CanonicalKindmaps all three tonotices.new-plugin --format retirements|feedscaffolds onnotices.Acceptance criteria
Extractfor every notices source (the versionedListVersions/ReadAt/Extractland in the next PR of the stack, I19.11;Runis already one for all)ShapeGuard)noticessource (a newPagereader; none registered here)Calls I made (please check)
feedmerged intonoticestoo, as asked for this rewrite ("retirements + feed + eol"); the ticket said feed stays its own kind and shares the steps from core. The feed readers are anoticesreader now.core/migratestill imports the deprecations-page and SDK-guide readers (for the v1 → v2 conversion), so those readers return v1 events and the kind converts them.Checks
make checkpasses (tidy, build, gofmt, vet, import allowlist, net/http guard,go test -race, noTODO(new-plugin), leak guard);make contractagainst patch-it'smainfixtures passes (11 files).plugins/notices/testdata/golden/(anthropic-models, openai-models, cloudflare, github-actions, vertex-ai-models, salesforce; 0 lines changed)Related PRs
apps/plugins-repo.md)v0.3.0(see "What the next bump changes" in the combined PR); the contract change this stack prepares for: patch-it-dev/patch-it#58 (adopted in a separate PR after it merges)🤖 Generated with Claude Code