Skip to content

merge retirements, feed and eol into one notices kind (I19.6) - #215

Merged
adssib merged 1 commit into
mainfrom
pl2-notices
Nov 21, 2026
Merged

adssib merged 1 commit into
mainfrom
pl2-notices

Conversation

@adssib

@adssib adssib commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Stacked on #214

Closes #177

What this changes

One notices kind for live pages of dated notices (I19.6): the deprecations pages (retirements), the RSS/Atom feeds (feed) and the end-of-life table (eol). plugins/notices has one Plugin whose Run does the shared steps once: fetch the live page, stop if unchanged, read it, the shape guard, snapshot and cite (kit.Cite), events from the snapshot, baseline. The readers live under it: notices/retire, notices/feed, notices/eol; each implements notices.Page (Slug, PageURL, Find, Events).

  • Options a reader turns on with a method: ShapeGuard() (fewer than 90% of the last read's notices is an error; the deprecations pages) and ArchiveWhenBlocked() (a 401/403 live page is read from a fresh Wayback snapshot; Salesforce).
  • Shared extractors move to core: the RSS/Atom parser and HTML text helpers are core/extract (notices/feed keeps its names as aliases). kit.Notices is what a reader returns.
  • plugins/retirements, plugins/retirements/retire, plugins/feed, plugins/eol stay as deprecated forwarders: retirements.Plugin{Page, Archiver}, eol.Plugin{Page: eol.Salesforce, Archiver} and feed.Plugin{Feed, Archiver} still compile and run the same events (tested). CanonicalKind maps all three to notices.
  • new-plugin --format retirements|feed scaffolds on notices.

Acceptance criteria

  • The moved goldens byte-identical (six pure renames, below)
  • One Extract for every notices source (the versioned ListVersions / ReadAt / Extract land in the next PR of the stack, I19.11; Run is already one for all)
  • The 90% guard is an option any reader can turn on (ShapeGuard)
  • Kubernetes API removals can be a notices source (a new Page reader; none registered here)

Calls I made (please check)

  • feed merged into notices too, as asked for this rewrite ("retirements + feed + eol"); the ticket said feed stays its own kind and shares the steps from core. The feed readers are a notices reader now.
  • The guard's error says "notices" instead of "retirements".
  • core/migrate still imports the deprecations-page and SDK-guide readers (for the v1 → v2 conversion), so those readers return v1 events and the kind converts them.

Checks

  • make check passes (tidy, build, gofmt, vet, import allowlist, net/http guard, go test -race, no TODO(new-plugin), leak guard); make contract against patch-it's main fixtures passes (11 files).
  • Goldens: six pure renames into plugins/notices/testdata/golden/ (anthropic-models, openai-models, cloudflare, github-actions, vertex-ai-models, salesforce; 0 lines changed)

Related PRs

🤖 Generated with Claude Code

One Plugin reads every live page of dated notices: fetch, unchanged
check, shape guard and blocked-page fallback as reader options, Wayback
cite, events, baseline. The deprecations-page, feed and end-of-life
readers live under plugins/notices; the RSS/Atom and HTML helpers move to
core/extract. The old packages only forward.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Signed-off-by: adssib <[email protected]>
@claude

claude Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Claude finished @adssib's task in 1m 22s —— View job


✅ Ready to merge. The merge keeps the same behaviour: the one notices.Run matches the three old Runs step for step, the six goldens are byte-identical renames, and every check I ran passes.

Rules

Rule Status Evidence
Plugin list (metadata in the registration) ✅ All six sources (openai/models, anthropic/models, github/actions, google/vertex-ai-models, cloudflare/api, salesforce/rest-api) are registered in plugins/notices/notices.go:33-88. Their id, name, category, homepage, layer, watches, URLs and page are word for word what they were before. No hand-kept list came back. TestSchemaEnumsMatchTheRegistry and TestTheListMatchesTheSchema pass with the new kind enum.
Provider page ✅ No new providers. The six pages only change their "Format plugin" line to name the notices kind and its reader. The Why this source sections are untouched.
Golden test + dated quote ✅ The six goldens are pure renames into plugins/notices/testdata/golden/ with 0 lines changed. The testdata READMEs moved too, and their URL, date, license and quote rows are unchanged; only the relative paths to the goldens were updated.
Drop test ✅ TestDropsAStillSupportedBand (eol), TestUnsureEntriesAreDropped and TestCloudflareNoActionForAPICallersIsNoEvent (feed), and TestOnlyTextModelsCodeSendsAreKept (retire) all moved over and pass.
Fetch only via env ✅ notices.fetch uses env.Get and Archiver.Snapshot only. core/extract parses bytes and does no I/O.
Nothing private ✅ leak_guard.py --all is clean. I found nothing internal in the code, docs, commit message or PR body.

Bugs

None found. I compared notices.Plugin.Run with the old retirements, feed and eol versions:

  • Shape guard: still only on the deprecations pages (retire.Page.ShapeGuard), and still compares with last.Content.
  • 401/403 → Wayback fallback: still only on eol.Page.
  • Cite check: kit.Cite's reflect.DeepEqual still works through the kit.Notices interface, because the live read and the snapshot read hold the same concrete slice type.
  • Baseline hash and v1 events: the baseline hash is still the live page's, and v1 events from retire still go through migrate.Fresh. Feed and eol never return v1 events, so for them the conversion does nothing.

Verified

  • go build ./...: OK
  • go vet ./...: OK
  • gofmt -l .: prints nothing
  • go test -race ./...: all packages pass, including plugins/notices, notices/{feed,retire}, the forwarders (plugins/{retirements,feed,eol}), cmd/new-plugin, internal/pluginlist and core/plugin (TestMergedKindsKeepWorking)
  • python3 scripts/leak_guard.py --all: "no banned terms (8 hashed terms checked)"
  • Not run: go run ./cmd/list-plugins needed approval in this sandbox, so I relied on the pluginlist schema tests instead. I didn't run make contract either.

Non-blocking

  • Forwarder compatibility: retirements.Plugin and eol.Plugin are now aliases of notices.Plugin, so Page is an interface. A composite literal like eol.Plugin{Page: eol.Salesforce, …} still compiles, but outside code that reads p.Page.API or p.Page.URL through the old type won't. If you care about that, a one-line note in the Deprecated comments would cover it. feed.Plugin keeps its own struct, so it isn't affected.
  • Comment wrapping: in plugins/notices/feed/feed.go:2, the package comment's second line runs far past the usual width. It reads like a missed re-wrap after the edit.
  • Your calls: both look reasonable to me.
    • Folding feed into notices: the reader interface fits feeds cleanly.
    • Rewording the guard's error from "retirements" to "notices": TestRetirementsRefuseAPageThatLostMostOfItsTables covers it.

Metadata: I read the six registrations against the base branch, and the words are unchanged and still accurate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

I19.6 · One notices kind

1 participant